Enhancement/noid/hash service #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@georgehrke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @raghunayyar, @tcitworld and @codeling to be potential reviewers. |
georgehrke
force-pushed
the
enhancement/noid/hash_service
branch
from
c5ed331
to
701be81
Compare
|
fixed the missing semicolon |
georgehrke
force-pushed
the
enhancement/noid/hash_service
branch
from
701be81
to
90000a0
Compare
tcitworld
reviewed
Dec 10, 2016
| @@ -136,6 +136,7 @@ module.exports = function(grunt) { | |||
| babel: { | |||
| options: { | |||
| presets: ['es2015'], | |||
| plugins: ["array-includes"], | |||
There was a problem hiding this comment.
Hmm, seems like String.prototype.includes (and same with array) is already available for our requirements : https://kangax.github.io/compat-table/es6/#test-String.prototype.contains
There was a problem hiding this comment.
Good catch!
Will remove it.
tcitworld
approved these changes
Dec 10, 2016
georgehrke
force-pushed
the
enhancement/noid/hash_service
branch
from
90000a0
to
632c84d
Compare
|
removed the babel plugin, let's wait for the tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements a hash_service
needed for:
#21
#41