Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable shared search and add ui test for list shares #5300

Merged
merged 5 commits into from
Feb 14, 2020
Merged

Re-enable shared search and add ui test for list shares #5300

merged 5 commits into from
Feb 14, 2020

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Jan 24, 2020 •
edited
Loading

Fix #4845

This helps as a quick win to get shared search back again.

Later we should separate this from remote search and create its own fragment.

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

@tobiasKaminsky tobiasKaminsky mentioned this pull request Jan 24, 2020
Closed
@nextcloud-android-bot
Copy link
Collaborator

IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12402-IT

@tobiasKaminsky tobiasKaminsky force-pushed the sharedSearchAgain branch 2 times, most recently from 19882be to 4c21739 Compare February 4, 2020 10:35
@tobiasKaminsky
Copy link
Member Author

SpotBugs increased!

No idea, where and why.
This is just too hard to compare…
We really should aim to get this down a lot :-)

@nextcloud-android-bot
Copy link
Collaborator

IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12557-IT

@tobiasKaminsky tobiasKaminsky force-pushed the sharedSearchAgain branch 2 times, most recently from 6344e8c to 8b8fa11 Compare February 10, 2020 11:21
@tobiasKaminsky
Add ui test for list shares
c2750aa 
add test user to drone
switch back to master
use "waitForIdleSync" instead of sleep

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky
Fix after rebase
26d7b9c 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Copy link
Collaborator

Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

3 similar comments
@nextcloud-android-bot
Copy link
Collaborator

Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@nextcloud-android-bot
Copy link
Collaborator

Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@nextcloud-android-bot
Copy link
Collaborator

Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@nextcloud-android-bot
Copy link
Collaborator

Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@nextcloud-android-bot
Copy link
Collaborator

IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12668-IT

@nextcloud-android-bot
Copy link
Collaborator

IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12669-IT

@nextcloud-android-bot
Copy link
Collaborator

Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@nextcloud-android-bot
Copy link
Collaborator

Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12671-Screenshot

@tobiasKaminsky
upload preliminary step
5cc0360 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Copy link
Collaborator

IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12674-IT

@nextcloud-android-bot
Copy link
Collaborator

Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@nextcloud-android-bot
Copy link
Collaborator

IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12675-Screenshot

@tobiasKaminsky
test
af93382 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Copy link
Collaborator

Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@nextcloud-android-bot
Copy link
Collaborator

IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12683-Screenshot

@tobiasKaminsky
test
6102752 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12695.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

457

Lint

TypemasterPR
Warnings7777
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings71
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings78
Security Warnings45
Dodgy code Warnings139
Total386

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings71
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings79
Security Warnings45
Dodgy code Warnings139
Total387

@codecov
Copy link

codecov bot commented Feb 14, 2020

Codecov Report

Merging #5300 into master will increase coverage by 1.86%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #5300      +/-   ##
============================================
+ Coverage     19.92%   21.79%   +1.86%     
  Complexity        3        3              
============================================
  Files           397      398       +1     
  Lines         33233    33326      +93     
  Branches       4663     4674      +11     
============================================
+ Hits           6622     7262     +640     
+ Misses        25528    24883     -645     
- Partials       1083     1181      +98
Impacted Files Coverage Δ Complexity Δ
...va/com/owncloud/android/ui/SquareLinearLayout.java 0.00% <0.00%> (-50.00%) 0.00% <0.00%> (ø%)
...c/main/java/com/nextcloud/client/account/Server.kt 66.66% <0.00%> (-33.34%) 0.00% <0.00%> (ø%)
...ava/com/nextcloud/client/account/RegisteredUser.kt 75.00% <0.00%> (-25.00%) 0.00% <0.00%> (ø%)
...java/com/nextcloud/client/account/AnonymousUser.kt 66.66% <0.00%> (-11.12%) 0.00% <0.00%> (ø%)
...n/java/com/owncloud/android/utils/BitmapUtils.java 42.67% <0.00%> (-4.46%) 0.00% <0.00%> (ø%)
...loud/android/datamodel/ThumbnailsCacheManager.java 27.92% <0.00%> (-4.21%) 0.00% <0.00%> (ø%)
...ava/com/owncloud/android/utils/DrawerMenuUtil.java 44.11% <0.00%> (-2.95%) 0.00% <0.00%> (ø%)
...om/owncloud/android/utils/FileSortOrderByName.java 14.28% <0.00%> (-2.86%) 0.00% <0.00%> (ø%)
...a/com/owncloud/android/utils/FileStorageUtils.java 24.88% <0.00%> (-1.92%) 0.00% <0.00%> (ø%)
.../third_parties/daveKoeller/AlphanumComparator.java 82.14% <0.00%> (-1.20%) 0.00% <0.00%> (ø%)
... and 47 more

@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.11.0 milestone Feb 14, 2020
@AndyScherzinger AndyScherzinger merged commit 490b292 into master Feb 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the sharedSearchAgain branch February 14, 2020 12:52
tobiasKaminsky added a commit that referenced this pull request Feb 15, 2020
@tobiasKaminsky
daily dev 20200215
6029548 
020e5a2 Merge remote-tracking branch 'origin/master' into dev
490b292 Merge pull request #5300 from nextcloud/sharedSearchAgain
6102752 test
af93382 test
68f06ea [tx-robot] updated from transifex
2d82f80 daily dev 20200214
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.11.0
Development

Successfully merging this pull request may close these issues.

The "Shared" item in Drawer (Shared Search Event) doesn't work ?
3 participants
@tobiasKaminsky @nextcloud-android-bot @AndyScherzinger