Files drop

[tobiasKaminsky]

according to #111

TODO:

• check for capabilities: [Stable9] Add files drop capability for clients server#888
• show compatibility pop up Warning about possible incompatibility to ownCloud #188

[AndyScherzinger]

This is an incompatible feature, right?
So we need some kind of feature detection for this if we want the app to still work well with oC backends. (which of course we could decide not to, but for now I would try to stay compatible).

[tobiasKaminsky]

This is nextcloud app for nextcloud server so it is fine for me ;-)
What is your opinion? @jancborchardt @przybylski

[tobiasKaminsky]

IMPORTANT: Do we need a server version check for nextcloud? When was this feature introduced...? @schiessle

[MariusBluem]

It was introduced with 9.0.50 ... So it was directly in the initial Nextcloud Release 😉
...using the app with ownCloud would require a version Check (if we want to keep it compatible 😁)

[tobiasKaminsky]

Ah, great :)
For me there is no need to have a version check against ownCloud.
If user should ever use the nextcloud app with an ownCloud server they should know that things can be broken.

[MariusBluem]

I agree with you @tobiasKaminsky

[AndyScherzinger]

Found one (minor) issue:

1. choose folder to share
2. activate "share link"
3. activate "allow editing"
4. activate "hide file listing"
5. deactivate "share link"

Issue: all "sub options" get hidden except for "hide file listing" which is still visible and set to active. This is just a UI thing though. In the background the folder got properly un-shared!

[Spacefish]

I would display a warning during the initial account adding inside the app, which tells the user, that ownCloud might be incompatible and that he may want to upgrade his server to next cloud.. however we loose all the users which may use the next cloud app but can't control the server installation (cooperate or educational users mainly)

[AndyScherzinger]

Issue #141 (comment) has been fixed: e71ae2e

[AndyScherzinger]

So tested and code reviewed: 👍

waiting for the second 👍

[AndyScherzinger]

@tobiasKaminsky do you think we can get a compatibility pop up done before the release so we can also ship this one? as in implement #188

[tobiasKaminsky]

@AndyScherzinger ready for test.
You will need nextcloud/android-library#16

[AndyScherzinger]

android lib has been merged, published via jitpack and referenced in this PR, see my latest commit.

Can't test it right now since Android Studio went nuts and corrupts the installation on the phone atm... :(

[AndyScherzinger]

Got it installed but never reached the check you implemented (not sure what is happening on my phone...). So my tests are negative at the moment :(

Will give it another try tomorrow.

[AndyScherzinger]

Code review and tests successful, waiting for the build to complete.