Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report client health #12009

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Report client health #12009

merged 1 commit into from
Dec 11, 2023

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Oct 9, 2023

  • Tests written, or not not needed

@tobiasKaminsky
Copy link
Member Author

/backport to stable-3.27

Copy link
Collaborator

@JonasMayerDev JonasMayerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaks the app for me right now. With dev apk and my server (latest release) logging in works totally fine but when closing and reopening the app, the app crashes directly with following error:

                                                                                                    Process: com.nextcloud.android.qa, PID: 6128
                                                                                                    java.lang.RuntimeException: Unable to instantiate application com.owncloud.android.MainApp package com.nextcloud.android.qa: java.lang.IllegalArgumentException: context is null
                                                                                                    	at android.app.LoadedApk.makeApplication(LoadedApk.java:1414)
                                                                                                    	at android.app.ActivityThread.handleBindApplication(ActivityThread.java:7059)
                                                                                                    	at android.app.ActivityThread.access$1800(ActivityThread.java:259)
                                                                                                    	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2208)
                                                                                                    	at android.os.Handler.dispatchMessage(Handler.java:106)
                                                                                                    	at android.os.Looper.loopOnce(Looper.java:233)
                                                                                                    	at android.os.Looper.loop(Looper.java:344)
                                                                                                    	at android.app.ActivityThread.main(ActivityThread.java:8248)
                                                                                                    	at java.lang.reflect.Method.invoke(Native Method)
                                                                                                    	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:589)
                                                                                                    	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1071)
                                                                                                    Caused by: java.lang.IllegalArgumentException: context is null
                                                                                                    	at android.accounts.AccountManager.get(AccountManager.java:586)
                                                                                                    	at com.owncloud.android.lib.common.OwnCloudAccount.<init>(OwnCloudAccount.java:75)
                                                                                                    	at com.nextcloud.client.account.UserAccountManagerImpl.createUserFromAccount(UserAccountManagerImpl.java:201)
                                                                                                    	at com.nextcloud.client.account.UserAccountManagerImpl.getUser(UserAccountManagerImpl.java:243)
                                                                                                    	at com.nextcloud.client.di.AppModule.uploadsStorageManager(AppModule.java:150)
                                                                                                    	at com.nextcloud.client.di.AppModule_UploadsStorageManagerFactory.uploadsStorageManager(AppModule_UploadsStorageManagerFactory.java:53)
                                                                                                    	at com.nextcloud.client.di.DaggerAppComponent$AppComponentImpl.uploadsStorageManager(DaggerAppComponent.java:6036)
                                                                                                    	at com.nextcloud.client.di.DaggerAppComponent$AppComponentImpl.injectMainApp(DaggerAppComponent.java:6968)
                                                                                                    	at com.nextcloud.client.di.DaggerAppComponent$AppComponentImpl.inject(DaggerAppComponent.java:6941)
                                                                                                    	at com.owncloud.android.MainApp.initDagger(MainApp.java:271)
                                                                                                    	at com.owncloud.android.MainApp.attachBaseContext(MainApp.java:249)
                                                                                                    	at android.app.Application.attach(Application.java:340)
                                                                                                    	at android.app.Instrumentation.newApplication(Instrumentation.java:1192)
                                                                                                    	at android.app.LoadedApk.makeApplication(LoadedApk.java:1406)
                                                                                                    	at android.app.ActivityThread.handleBindApplication(ActivityThread.java:7059) 
                                                                                                    	at android.app.ActivityThread.access$1800(ActivityThread.java:259) 
                                                                                                    	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2208) 
                                                                                                    	at android.os.Handler.dispatchMessage(Handler.java:106) 
                                                                                                    	at android.os.Looper.loopOnce(Looper.java:233) 
                                                                                                    	at android.os.Looper.loop(Looper.java:344) 
                                                                                                    	at android.app.ActivityThread.main(ActivityThread.java:8248) 
                                                                                                    	at java.lang.reflect.Method.invoke(Native Method) 
                                                                                                    	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:589) 
                                                                                                    	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1071) 
2023-12-11 12:39:32.005  6128-6128  Process                 com.nextcloud.android.qa             I  Sending signal. PID: 6128 SIG: 9

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Copy link

Codacy

Lint

TypemasterPR
Warnings7373
Errors33

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness6868
Dodgy code360360
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5555
Security1818
Total549549

Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12009.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@tobiasKaminsky tobiasKaminsky merged commit fee31e6 into master Dec 11, 2023
19 of 20 checks passed
@delete-merged-branch delete-merged-branch bot deleted the health branch December 11, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants