Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directories containing ":" in their filename are not downloaded (synced) by the client #685

Closed
elpraga opened this issue Feb 26, 2017 · 16 comments
Labels
bug hotspot: device storage Storage (on-device) related. Permissions, paths, inconsistencies, etc.

Comments

@elpraga
Copy link

elpraga commented Feb 26, 2017

Actual behaviour

It a directory name contains ":", the download of files within fails both in 1.4.1 and current Beta apps.

Expected behaviour

Files get downloaded.

Steps to reproduce

  1. Synchronize a directory containing a ":" in a name using a desktop client.
  2. Try to download any file within it using an Android app.

Environment data

Android version:
6.0

Device model:
Huawei Y6II

Stock or customized system:
stock
Nextcloud app version:
1.4.1 and Beta

Nextcloud server version:
11.0.1

@tobiasKaminsky tobiasKaminsky added bug needs info Waiting for info from user(s). Issues with this label will auto-stale. labels Apr 4, 2017
@tobiasKaminsky
Copy link
Member

Same as in #684 it worked for me with linux and android 7.
What desktop client are you using?

@elpraga
Copy link
Author

elpraga commented Apr 4, 2017 via email

@tobiasKaminsky
Copy link
Member

Same as #684 , please reopen if it happens again and then post the filename.

@elpraga
Copy link
Author

elpraga commented Jun 17, 2017

Ok @tobiasKaminsky , I ran into this issue again. I have to note that i cannot reproduce it using the dev client, only the 1.4.3 version.

My settings:
storage on SD card.
Steps to reproduce:

  • upload a file containing a ":" in the name.
  • try to download it using the 1.4.3 version of the client.
    Download will fail.

@elpraga
Copy link
Author

elpraga commented Jun 18, 2017

P.S. There is no way for me to reopen the issue, but please check if you can reproduce it.

@elpraga
Copy link
Author

elpraga commented Jun 19, 2017

Were you able to reproduce the error @tobiasKaminsky ? I know you mentioned earlier that you were not able to reproduce the behavior..

@tobiasKaminsky
Copy link
Member

I can reproduce it with a Samsung S5 and using SDcard as storage for our app.
I think this is a problem from android as I cannot rename an image with a file manager nor I cannot rename it via ADB.
Reading some issues on google I think this is related to the formatting of the sdcard which does not support such special characters.
Maybe this is handled better in Android 7 and external sdcard.

@elpraga
Copy link
Author

elpraga commented Jun 19, 2017

That's what I thought as well, but I can work just fine with the same file using the dev app. Might it be an issue of in internal storage instead? Doesn't the 1.4.3 download the file first to internal storage and then to the SDcard?

@tobiasKaminsky
Copy link
Member

As far as I know we did not change the download process, but I will have a look.

@elpraga
Copy link
Author

elpraga commented Jun 20, 2017

One of the apps has to behave like this, because I get a folder called nextcloud created in my internal storage even though I have the SDCard selected as the place to store files in the app.

@tobiasKaminsky
Copy link
Member

The initial storage is always internal, so on your very first start there will be a nextcloud folder created.

@elpraga
Copy link
Author

elpraga commented Jun 20, 2017 via email

@tobiasKaminsky
Copy link
Member

I tried it with several devices, this is my conclusion:

  • internal storage --> no problems
  • sdcard mounted/formatted as internal storage -> no problems
  • sdcard mounted/formatted as portable storage --> download error

Can you verify with a file explorer where the file (when it is working) gets downloaded? And how the sdcard is formatted/mounted?

@elpraga
Copy link
Author

elpraga commented Jun 22, 2017

I can confirm, internal storaga -> no problem
SD card -> download error in both 1.4.3 and the dev app (the last update of the dev app changed the storage to internal again, and that's why I didn't noticed it)

SD Card:
Storage type: USER_EXTERNAL
DEVICE: /dev/fuse

That's what I got form FX File manager. Does it help?

@tobiasKaminsky
Copy link
Member

Thank you for your infos.
A quick search leads me to the impression that the external sdcard is forrmatted as vfat which cannot handle ":" as filename.
I am really sorry but I doubt that we can do anything here. If you really need to have these filenames you will have to use the internal storage, or wait for an android update that allows you to format your sdcard as internal storage.
If you agree, please close.

@elpraga
Copy link
Author

elpraga commented Jun 23, 2017

Ok. Thank you for investigating the issue!

@elpraga elpraga closed this as completed Jun 23, 2017
@joshtrichards joshtrichards added hotspot: device storage Storage (on-device) related. Permissions, paths, inconsistencies, etc. and removed needs info Waiting for info from user(s). Issues with this label will auto-stale. labels Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug hotspot: device storage Storage (on-device) related. Permissions, paths, inconsistencies, etc.
Projects
None yet
Development

No branches or pull requests

3 participants