Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(download): Use specific code and exception when download fails to create local file #1069

Merged
merged 3 commits into from
Feb 17, 2023

Conversation

AlvaroBrey
Copy link
Member

No description provided.

@github-actions
Copy link
Contributor

SpotBugs (new)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 140

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #1069 (33f13be) into master (b610a4a) will decrease coverage by 0.06%.
The diff coverage is 42.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1069      +/-   ##
==========================================
- Coverage   49.35%   49.30%   -0.06%     
==========================================
  Files         179      180       +1     
  Lines        6739     6750      +11     
  Branches      895      897       +2     
==========================================
+ Hits         3326     3328       +2     
- Misses       2945     2953       +8     
- Partials      468      469       +1     
Impacted Files Coverage Δ
...d/lib/common/operations/RemoteOperationResult.java 45.29% <0.00%> (-0.53%) ⬇️
...b/resources/files/DownloadFileRemoteOperation.java 44.08% <42.85%> (-0.86%) ⬇️
...id/lib/resources/files/CreateLocalFileException.kt 100.00% <100.00%> (ø)
...wncloud/android/lib/resources/files/FileUtils.java 71.42% <0.00%> (-14.29%) ⬇️

@github-actions
Copy link
Contributor

SpotBugs (new)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 140

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

@github-actions
Copy link
Contributor

SpotBugs (new)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 140

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

@tobiasKaminsky
Copy link
Member

This needs a corresponding files PR, otherwise new ResultCode is not correct understood and "unknown error" is shown, right?

@AlvaroBrey
Copy link
Member Author

This needs a corresponding files PR, otherwise new ResultCode is not correct understood and "unknown error" is shown, right?

Yes, PR is nextcloud/android#11384

AlvaroBrey and others added 3 commits February 17, 2023 10:12
…o create local file

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
…d by invalid filepath

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
@github-actions
Copy link
Contributor

SpotBugs (new)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 140

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

@AlvaroBrey AlvaroBrey merged commit 7d15d0b into master Feb 17, 2023
@delete-merged-branch delete-merged-branch bot deleted the invalid-path-download branch February 17, 2023 09:36
@AlvaroBrey
Copy link
Member Author

/backport to stable-2.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants