Catch errors when one email could not be sent #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <coding@schilljs.com>
|
Tested by @volker-raschek in nextcloud/server#1716 (comment) Counting as 👍 @MorrisJobke second review? |
MorrisJobke
reviewed
Oct 13, 2016
|
|
||
| try { | ||
| $this->mailer->send($message); | ||
| } catch (\Exception $e) { |
There was a problem hiding this comment.
This is always really bad 🙈 Then an exception is simply dropped - at least having it in debug mode visible would make this traceable.
There was a problem hiding this comment.
It's logged one step outside in lib/BackgroundJob/EmailNotification.php:
$this->logger->debug("Failed sending activity mail to user '" . $user . "'.", ['app' => 'activity']);
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix nextcloud/server#1716