Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add daily activity digest option #483

Merged
merged 4 commits into from
Aug 21, 2020
Merged

add daily activity digest option #483

merged 4 commits into from
Aug 21, 2020

Conversation

icewind1991
Copy link
Member

  • Per user option to enable digest mails
  • Digest includes up to 20 activity items from the last day
  • If more then 20 activity items exist for the last day, "and %n more" will be added to the mail.
  • Email format based on the notification mails:

image

@rullzer
Copy link
Member

rullzer commented Aug 14, 2020

@jancborchardt should we also here filter out your own actions?

@nickvergessen
Copy link
Member

This can be achieved already via https://docs.nextcloud.com/server/16/admin_manual/configuration_server/activity_configuration.html#better-scheduling-of-activity-emails

But yeah then it affects all users, but we have less duplicate code?

@rullzer
Copy link
Member

rullzer commented Aug 14, 2020

This can be achieved already via https://docs.nextcloud.com/server/16/admin_manual/configuration_server/activity_configuration.html#better-scheduling-of-activity-emails

But yeah then it affects all users, but we have less duplicate code?

Always good!

@jancborchardt
Copy link
Member

@jancborchardt should we also here filter out your own actions?

Yes – any kind of notification should always filter out anything you do yourself.

(The "Activity" list doesn’t notify, so it’s fine to show your own actions there.)

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments for wording and structure improvements.

Is it possible to get avatars and file previews here instead of only the updated/created/deleted icons? That would be much much nicer.

lib/DigestSender.php Outdated Show resolved Hide resolved
lib/DigestSender.php Outdated Show resolved Hide resolved
lib/DigestSender.php Outdated Show resolved Hide resolved
templates/settings/personal.php Outdated Show resolved Hide resolved
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
Copy link
Member Author

Is it possible to get avatars and file previews here instead of only the updated/created/deleted icons?

that's would be a fair amount of work to properly handle authentication of the preview urls, I'll look into it in a follow up PR if there is enough time.

…plied

Signed-off-by: Joas Schilling <coding@schilljs.com>
lib/DigestSender.php Outdated Show resolved Hide resolved
Co-authored-by: Morris Jobke <hey@morrisjobke.de>
@rullzer rullzer mentioned this pull request Aug 21, 2020
19 tasks
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed lets do this!

@nickvergessen nickvergessen merged commit 6460cf8 into master Aug 21, 2020
@MorrisJobke MorrisJobke deleted the activity-digest branch August 21, 2020 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants