Skip parameters which are not there instead of failing out #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
reviewed
Apr 4, 2018
| @@ -45,8 +45,12 @@ | |||
|
|
|||
| _.each(matches, function(parameter) { | |||
| parameter = parameter.substring(1, parameter.length - 1); | |||
| var parsed = self.parseParameter(parameters[parameter]); | |||
| if (!parameters.hasOwnProperty(parameter) || !parameters[parameter]) { | |||
| // Malformed translation? | |||
There was a problem hiding this comment.
should this be reported instead of failing silently?
There was a problem hiding this comment.
Well only thing would be console.log, but that is disabled for non-debug anyway, so I don't think it's important.
There was a problem hiding this comment.
so, wouldn't it be helpful for debugging? for the app dev to to find out where an issues occurs?
There was a problem hiding this comment.
whatever I was thinking, yes of course, amended
|
travis is unhapy |
|
Travis was fixed with https://github.com/nextcloud/activity/pull/259/files But I will rebase |
nickvergessen
force-pushed
the
bugfix/256/skip-on-error
branch
from
6de54e7
to
92b9084
Compare
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
bugfix/256/skip-on-error
branch
from
92b9084
to
3da098f
Compare
blizzz
approved these changes
Apr 10, 2018
|
@nickvergessen Next RC is coming - time for backport |
This was referenced Apr 18, 2018
|
@nickvergessen To backport or not to backport? |
|
ws already backported see #265 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #256
Fix #77
Testing today:
Testing tomorrow:
See above + revert #256 (comment)
Expected
Actual