Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't send emails to disabled users #181

Merged
merged 2 commits into from
Aug 2, 2017
Merged

Don't send emails to disabled users #181

merged 2 commits into from
Aug 2, 2017

Conversation

nickvergessen
Copy link
Member

Fix #178

@nickvergessen
Don't send emails to disabled users
1cf12c9 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Delete email entries of users without email so the queue gets empty
253054d 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 13 milestone Aug 2, 2017
tcitworld
tcitworld approved these changes Aug 2, 2017
View reviewed changes
Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue, but maybe it could be even better if activities were not generated at all for disabled users ?

@nickvergessen
Copy link
Member Author

Yeah that's a different issue and needs to be done and fixed in the apps that create them

@nickvergessen nickvergessen merged commit 982d226 into master Aug 2, 2017
@nickvergessen nickvergessen deleted the issue-178-no-emails-for-disabled-users branch August 2, 2017 09:18
@MorrisJobke
Copy link
Member

@nickvergessen Mind to do the backport?

@nickvergessen
Copy link
Member Author

#202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcitworld tcitworld tcitworld approved these changes

Assignees
No one assigned
Labels
3. to review bug feature: email
Projects
None yet
Milestone
Nextcloud 13
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @MorrisJobke @tcitworld