Migrate activity app from ILogger #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fenn-CS
force-pushed
the
32127-migrate-activity-app-from-ilogger
branch
2 times, most recently
from
78e2b12
to
ca24670
Compare
|
Is this still a draft? |
Yes @artonge ... Sorry, would update it and tag for review this week. |
Migrated files in: - `lib\AppInfo` - `lib\Controller` - `lib\Command` Resolves : nextcloud/server#32127 Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Migrate all root classes in `lib` to standard PSR logger. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Fenn-CS
force-pushed
the
32127-migrate-activity-app-from-ilogger
branch
from
ca24670
to
7e6ff19
Compare
Fenn-CS
force-pushed
the
32127-migrate-activity-app-from-ilogger
branch
9 times, most recently
from
39f76ca
to
e5fb619
Compare
- Use constructor property promotion - Some logger updates - Fix some issues with static analysis Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
There should be a space between the actual commands and its flags Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Fenn-CS
force-pushed
the
32127-migrate-activity-app-from-ilogger
branch
from
e5fb619
to
514fd52
Compare
artonge
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated files in:
lib\AppInfolib\Controllerlib\Commandlib\(Classes in root)Resolves : nextcloud/server#32127