Skip to content

Commit

Permalink
chore: set version in composer.json
Browse files Browse the repository at this point in the history
When running dump-autoload, then composer tries to find a matching version number.

Sometimes the VCS detection does not work and the generated version number changes from the commit hash to the fallback and back to the generated version when someone else updates the package.

We are now using a version number in composer.json to avoid a version number ping-pong.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
  • Loading branch information
kesselb committed Jul 4, 2024
1 parent 72598dd commit 2075916
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 7 deletions.
1 change: 1 addition & 0 deletions composer.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"name": "nextcloud/3rdparty",
"version": "dev-master",
"description": "All 3rdparty components",
"license": "MIT",
"config": {
Expand Down
10 changes: 5 additions & 5 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions composer/installed.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
'name' => 'nextcloud/3rdparty',
'pretty_version' => 'dev-master',
'version' => 'dev-master',
'reference' => '5d619fb1d9e9f28e5b6ceeef5fd59a85b1965e38',
'reference' => NULL,
'type' => 'library',
'install_path' => __DIR__ . '/../',
'aliases' => array(),
Expand Down Expand Up @@ -292,7 +292,7 @@
'nextcloud/3rdparty' => array(
'pretty_version' => 'dev-master',
'version' => 'dev-master',
'reference' => '5d619fb1d9e9f28e5b6ceeef5fd59a85b1965e38',
'reference' => NULL,
'type' => 'library',
'install_path' => __DIR__ . '/../',
'aliases' => array(),
Expand Down

0 comments on commit 2075916

Please sign in to comment.