Always use the normal action and just make the execution dependent on…

… the changed files Signed-off-by: Joas Schilling <coding@schilljs.com>
nextcloud · Oct 10, 2023 · 25accf4 · 25accf4
1 parent b41c534
commit 25accf4
Show file tree

Hide file tree

Showing 12 changed files with 168 additions and 466 deletions.
diff --git a/workflow-templates/lint-eslint-when-unrelated.properties.json b/workflow-templates/lint-eslint-when-unrelated.properties.json
diff --git a/workflow-templates/lint-eslint-when-unrelated.yml b/workflow-templates/lint-eslint-when-unrelated.yml
diff --git a/workflow-templates/lint-eslint.yml b/workflow-templates/lint-eslint.yml
@@ -10,18 +10,6 @@ name: Lint eslint
 
 on:
   pull_request:
-    paths:
-      - '.github/workflows/**'
-      - 'src/**'
-      - 'appinfo/info.xml'
-      - 'package.json'
-      - 'package-lock.json'
-      - 'tsconfig.json'
-      - '.eslintrc.*'
-      - '.eslintignore'
-      - '**.js'
-      - '**.ts'
-      - '**.vue'
 
 permissions:
   contents: read
@@ -31,10 +19,31 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
+  changes:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: dorny/paths-filter@4512585405083f25c027a35db413c2b3b9006d50 # v2.11.1
+        id: changes
+        with:
+          filters: |
+            src:
+              - '.github/workflows/**'
+              - 'src/**'
+              - 'appinfo/info.xml'
+              - 'package.json'
+              - 'package-lock.json'
+              - 'tsconfig.json'
+              - '.eslintrc.*'
+              - '.eslintignore'
+              - '**.js'
+              - '**.ts'
+              - '**.vue'
+
   lint:
     runs-on: ubuntu-latest
 
-    name: eslint
+    name: NPM lint
 
     steps:
       - name: Checkout
@@ -62,3 +71,18 @@ jobs:
 
       - name: Lint
         run: npm run lint
+
+  summary:
+    permissions:
+      contents: none
+    runs-on: ubuntu-latest
+    needs: build
+
+    if: always()
+
+    # This is the summary, we just avoid to rename it so that branch protection rules still match
+    name: eslint
+
+    steps:
+      - name: Summary status
+        run: if ${{ steps.changes.outputs.src == 'true' && needs.lint.result != 'success' }}; then exit 1; fi
diff --git a/workflow-templates/node-when-unrelated.properties.json b/workflow-templates/node-when-unrelated.properties.json
diff --git a/workflow-templates/node-when-unrelated.yml b/workflow-templates/node-when-unrelated.yml
diff --git a/workflow-templates/node.yml b/workflow-templates/node.yml
@@ -7,16 +7,6 @@ name: Node
 
 on:
   pull_request:
-    paths:
-      - '.github/workflows/**'
-      - 'src/**'
-      - 'appinfo/info.xml'
-      - 'package.json'
-      - 'package-lock.json'
-      - 'tsconfig.json'
-      - '**.js'
-      - '**.ts'
-      - '**.vue'
   push:
     branches:
       - main
@@ -31,10 +21,31 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
+  changes:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: dorny/paths-filter@4512585405083f25c027a35db413c2b3b9006d50 # v2.11.1
+        id: changes
+        with:
+          filters: |
+            src:
+              - '.github/workflows/**'
+              - 'src/**'
+              - 'appinfo/info.xml'
+              - 'package.json'
+              - 'package-lock.json'
+              - 'tsconfig.json'
+              - '**.js'
+              - '**.ts'
+              - '**.vue'
+
   build:
     runs-on: ubuntu-latest
 
-    name: node
+    if: steps.changes.outputs.src == 'true'
+
+    name: NPM build
     steps:
       - name: Checkout
         uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3.6.0
@@ -71,3 +82,18 @@ jobs:
           git status
           git --no-pager diff
           exit 1 # make it red to grab attention
+
+  summary:
+    permissions:
+      contents: none
+    runs-on: ubuntu-latest
+    needs: build
+
+    if: always()
+
+    # This is the summary, we just avoid to rename it so that branch protection rules still match
+    name: node
+
+    steps:
+      - name: Summary status
+        run: if ${{ steps.changes.outputs.src == 'true' && needs.build.result != 'success' }}; then exit 1; fi