Read instance category on update check #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Altahrim
force-pushed
the
feat/add_instance_category
branch
from
cadefb5
to
b095c0f
Compare
artonge
approved these changes
Jul 12, 2023
skjnldsv
approved these changes
Jul 12, 2023
blizzz
reviewed
Jul 12, 2023
| $this->remoteAddress = (isset($server['REMOTE_ADDR']) ? $server['REMOTE_ADDR'] : ''); | ||
| switch (count($version)) { | ||
| case 14: | ||
| $this->isSubscriber = (int) $version[13]; |
There was a problem hiding this comment.
does it mean we rely on the client to provide reliable subscription information?
There was a problem hiding this comment.
Yes,I implemented it here : nextcloud/server#39264
I didn't find any other way, but we can discuss it if you have some time :)
blizzz
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to read new attributes
categoryandisSubscriberfrom update check