Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add SettingsInputText compontents #650

Merged
merged 1 commit into from
Oct 12, 2020
Merged

add SettingsInputText compontents #650

merged 1 commit into from
Oct 12, 2020

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Oct 14, 2019

No description provided.

@GretaD GretaD self-assigned this Oct 14, 2019
@GretaD GretaD added 3. to review Waiting for reviews component Component discussion and/or suggestion labels Oct 14, 2019
@juliusknorr juliusknorr mentioned this pull request Dec 2, 2019
Closed
@GretaD GretaD force-pushed the add_SettingsInputTex_components branch from 793aa63 to 9253d58 Compare February 27, 2020 13:45
skjnldsv
skjnldsv previously requested changes Apr 22, 2020
View reviewed changes
src/components/SettingsInputText/SettingsInputText.vue Outdated Show resolved Hide resolved
src/components/SettingsInputText/SettingsInputText.vue Outdated Show resolved Hide resolved
src/components/SettingsInputText/SettingsInputText.vue Outdated Show resolved Hide resolved
src/components/SettingsInputText/SettingsInputText.vue Outdated Show resolved Hide resolved
src/components/SettingsInputText/SettingsInputText.vue Outdated Show resolved Hide resolved
src/components/SettingsInputText/SettingsInputText.vue Outdated Show resolved Hide resolved
src/components/SettingsInputText/SettingsInputText.vue Outdated Show resolved Hide resolved
src/components/SettingsInputText/index.js Outdated Show resolved Hide resolved
@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Apr 22, 2020
@GretaD GretaD force-pushed the add_SettingsInputTex_components branch 3 times, most recently from ac1bbc0 to 26dcfc7 Compare June 15, 2020 11:30
@GretaD GretaD requested a review from skjnldsv June 15, 2020 11:31
@GretaD GretaD force-pushed the add_SettingsInputTex_components branch from 26dcfc7 to 848cd4d Compare June 22, 2020 15:51
@GretaD GretaD requested a review from juliusknorr June 22, 2020 15:53
ChristophWurst
ChristophWurst approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@GretaD GretaD added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Oct 7, 2020
skjnldsv
skjnldsv approved these changes Oct 10, 2020
View reviewed changes
Copy link
Contributor

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments to fix :)
Looks good otherwise!

@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 4. to release Ready to be released and/or waiting for tests to finish labels Oct 10, 2020
@GretaD
add SettingsInputText compontents
9878e70 
Signed-off-by: Greta Doci <gretadoci@gmail.com>
@GretaD GretaD force-pushed the add_SettingsInputTex_components branch from 848cd4d to 9878e70 Compare October 12, 2020 11:50
@GretaD GretaD merged commit 326f6df into master Oct 12, 2020
@GretaD GretaD deleted the add_SettingsInputTex_components branch October 12, 2020 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@georgehrke georgehrke Awaiting requested review from georgehrke

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@GretaD GretaD

Labels
3. to review Waiting for reviews component Component discussion and/or suggestion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GretaD @georgehrke @ChristophWurst @juliusknorr @skjnldsv