-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NcAppNavigationItem): Add prop to show collapse icon #5940
Conversation
Signed-off-by: Christopher Ng <chrng8@gmail.com>
What is the use case? So when do you want collapsible behavior but not the toggle? Having a collapsible item without toggle seems very inconsistent to me and should probably go through a design decision so we do not end up with inconsistent app navigation design. |
cc @jancborchardt would this be a blocker to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fully agree with @susnux. What’s the use-case for this? Otherwise it seems like an unnecessary prop.
To me it seems the use case should be: I think is quite an edge case and adding a prop for that will lead to inconsistency, because people will misuse it. But there are some other options:
|
The use case is showing the collapse icon even when there are no children in the default slot yet so the user can click expand which triggers loading of the children
I think this sounds like the same as showCollapse as this would also need a new prop to force this and without a prop it would break existing design and show the collapse icon everywhere by default Maybe we could name it forceShowCollapse? |
But this is already possible? You do not need a prop for this, you just need to make sure the slot is available, like: <NcAppNavigationItem ...>
<template>
<li style="display: none"></li>
</template>
</NcAppNavigationItem> |
Sure can do it this way! Still seems like more of a hack than showCollapse imo 🙈 |
☑️ Resolves
Adds opt-in showCollapse to override internal collapsible state
🏁 Checklist
next
requested with a Vue 3 upgrade