Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcListItem): do not render counter on falsy values #5834

Merged
merged 1 commit into from
Jul 18, 2024
Merged

fix(NcListItem): do not render counter on falsy values #5834

merged 1 commit into from
Jul 18, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jul 18, 2024 •
edited by ShGKme
Loading

☑️ Resolves

  • Fix empty container, if counter has been passed as falsy value, but not 0 (null)

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@Antreesy
fix(NcListItem): do not render counter on falsy values
2f9f51e 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews feature: list-item Related to the list-item component labels Jul 18, 2024
@Antreesy Antreesy added this to the 8.14.1 milestone Jul 18, 2024
@Antreesy Antreesy requested review from susnux, Pytal and ShGKme July 18, 2024 19:23
@Antreesy Antreesy self-assigned this Jul 18, 2024
@Antreesy
Copy link
Contributor Author

/backport to next

@susnux susnux merged commit 3551aee into master Jul 18, 2024
19 checks passed
@susnux susnux deleted the fix/noid/nclistitem-counter-null branch July 18, 2024 21:09
@backportbot backportbot bot mentioned this pull request Jul 18, 2024
Merged
@Antreesy Antreesy mentioned this pull request Jul 22, 2024
Merged
@susnux susnux modified the milestones: 8.14.1, 8.15.0 Jul 22, 2024
This was referenced Aug 14, 2024
Open
Open
@Stanislav1975 Stanislav1975 mentioned this pull request Aug 26, 2024
Open
This was referenced Sep 6, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@ShGKme ShGKme ShGKme approved these changes

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@Antreesy Antreesy

Labels
3. to review Waiting for reviews bug Something isn't working feature: list-item Related to the list-item component
Projects
None yet
Milestone
8.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @susnux @ShGKme