Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcInputField): Make sure label and placeholder is not jumping #5821

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 18, 2024

☑️ Resolves

Rework layout logic to ensure the label is not jumping on focus. This was caused as our border width changes when focusing.

🖼️ Screenshots

Before

vokoscreenNG-2024-07-18_02-44-45.webm

After

vokoscreenNG-2024-07-18_02-42-29.webm

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@susnux susnux added bug Something isn't working 3. to review Waiting for reviews feature: input-field Covering the InputField, TextField, ... labels Jul 18, 2024
@susnux susnux requested review from Pytal, ShGKme and Antreesy July 18, 2024 00:46
@susnux
Copy link
Contributor Author

susnux commented Jul 18, 2024

/backport to next

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/components/NcInputField/NcInputField.vue Show resolved Hide resolved
Rework layout logic to ensure the label is not jumping on focus.
This was caused as our border width changes when focusing.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux merged commit 0febe32 into master Jul 18, 2024
19 checks passed
@susnux susnux deleted the fix/input-field branch July 18, 2024 15:46
@susnux susnux added this to the 8.14.1 milestone Jul 18, 2024
@susnux
Copy link
Contributor Author

susnux commented Jul 18, 2024

/backport to next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: input-field Covering the InputField, TextField, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants