[next] fix(NcDateTime): When relative time is disabled return a string and not the reference to it #5506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](https://github.com/avatars/in/60201?s=60&v=4){kind=small}
backportbot
bot
added
bug
…ot the reference to it The `.value` call was missing in case of disabled relative time. This causes the string to be quoted (because of stringification of the computed value). To prevent similar issues the file is now migrated to Typescript, also fixed some other issues discovered by type checking. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
backport/5493/next
branch
from
cf479fa
to
2fb45d9
Compare
ShGKme
approved these changes
Apr 21, 2024
Comment on lines
-112
to
+113
| :title="formattedFullTime">{{ formattedTime }}</span> | ||
| :title="formattedFullTime" | ||
| v-text="formattedTime" /> |
There was a problem hiding this comment.
Why replace text content with v-text directive?
There was a problem hiding this comment.
Weird formatting fix, probably
<span ...
...>
{{ ... }}
</span>
Is what was intended - I can revert as this is unrelated.
There was a problem hiding this comment.
(while I wanted to do so right now I noticed in this case it looks cleaner the way it is now, wdyt?)
emoral435
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #5493
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.