Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcDateTime): Respect language #5501

Merged
merged 2 commits into from
Apr 22, 2024
Merged

fix(NcDateTime): Respect language #5501

merged 2 commits into from
Apr 22, 2024

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Apr 17, 2024 •
edited
Loading

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@Pytal Pytal added bug Something isn't working 3. to review Waiting for reviews labels Apr 17, 2024
@Pytal Pytal added this to the 8.11.3 milestone Apr 17, 2024
@Pytal Pytal requested review from susnux, Fenn-CS and ShGKme April 17, 2024 17:52
@Pytal Pytal self-assigned this Apr 17, 2024
@Pytal Pytal enabled auto-merge April 17, 2024 17:53
@Pytal Pytal force-pushed the fix/date-time-lang branch 2 times, most recently from 45a124a to 8009bbb Compare April 17, 2024 18:03
@Pytal
Copy link
Contributor Author

Pytal commented Apr 17, 2024

/backport to next

susnux
susnux requested changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work, for example I have configured Nextcloud to use English (US) lanuage, but German locale (I want 24h system and dd.mm.yyyy days but English texts).
Now also english

src/composables/useFormatDateTime.js Outdated Show resolved Hide resolved
@Pytal Pytal force-pushed the fix/date-time-lang branch 2 times, most recently from 7876363 to 3149903 Compare April 19, 2024 17:40
@Pytal Pytal requested a review from susnux April 19, 2024 17:44
susnux
susnux approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ShGKme
ShGKme approved these changes Apr 19, 2024
View reviewed changes
tests/unit/components/NcDateTime/NcDateTime.spec.js Outdated Show resolved Hide resolved
tests/unit/components/NcDateTime/NcDateTime.spec.js Outdated Show resolved Hide resolved
@ShGKme ShGKme disabled auto-merge April 19, 2024 19:51
@susnux
Copy link
Contributor

susnux commented Apr 22, 2024

@Pytal conflicts + maybe include Grigoriis comments :)

@Pytal
fix(NcDateTime): Respect language
846ebea 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
test(NcDateTime): Works with different languages
4f57f6d 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal enabled auto-merge April 22, 2024 23:42
@Pytal Pytal merged commit e7ef548 into master Apr 22, 2024
18 checks passed
@Pytal Pytal deleted the fix/date-time-lang branch April 22, 2024 23:46
@backportbot backportbot bot mentioned this pull request Apr 22, 2024
Merged
2 tasks
@Antreesy Antreesy mentioned this pull request May 7, 2024
Merged
@skjnldsv skjnldsv mentioned this pull request Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@ShGKme ShGKme ShGKme approved these changes

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Milestone
8.11.3
Development

Successfully merging this pull request may close these issues.

Timestamps are not displayed in the preferred language
3 participants
@Pytal @susnux @ShGKme