fix: NcUserBubble properties #4743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Examples does not need to pass computed property * `alert` is not defined in templates for Vue 2 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
We already have a fallback so it is not required. But we should show a warning when user and display name are not set. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
added
bug
ShGKme
approved these changes
Nov 2, 2023
Pytal
reviewed
Nov 2, 2023
| @@ -0,0 +1,6 @@ | |||
| declare const PRODUCTION: boolean | |||
There was a problem hiding this comment.
Is this related?
skjnldsv
approved these changes
Nov 3, 2023
Pytal
approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
displayNamenot requiredWe already have a fallback so it is not required.
But we should show a warning when user and display name are not set.
alertis not defined in templates for Vue 2 (same with console)🏁 Checklist