Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcActions): Allow to set attributes to inline actions #4671

Merged
merged 1 commit into from
Oct 19, 2023
Merged

fix(NcActions): Allow to set attributes to inline actions #4671

merged 1 commit into from
Oct 19, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Oct 19, 2023

☑️ Resolves

Currently inline action do not receive the attributes set on them, this PR allows to set e.g. data-test-id to buttons for integration tests.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@susnux
fix(NcActions): Allow to set attributes to inline actions
02bf90a 
Allowing to set e.g. `data-test-id` to buttons for integration tests.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug Something isn't working 3. to review Waiting for reviews feature: actions Related to the actions components labels Oct 19, 2023
ShGKme
ShGKme approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to pass attributes, thought, we should try not use data-test-id here for testing, and use any semantic value (e.g. text).

@skjnldsv skjnldsv merged commit 8b70001 into master Oct 19, 2023
15 checks passed
@skjnldsv skjnldsv deleted the fix/actions-allow-attrs branch October 19, 2023 13:56
@Pytal Pytal mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@ShGKme ShGKme ShGKme approved these changes

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working feature: actions Related to the actions components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@susnux @skjnldsv @ShGKme