Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcSelect): make id truly uniqual #4606

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Oct 4, 2023

☑️ Resolves

VueSelect generates unique IDs for some elements. But it is just auto-increment id. For example, #vs1-compobox.

It works fine while only one copy of VueSelect (@nextcloud/vue) is used. Otherwise, there are several VueSelects with their own uid sequence. Then there are many #vs1-compobox elements on the page.

This PR defines a default value for VueSelect.uid with a random string.

Now nc-selects have IDs like #vs-wxtrv-compobox

🖼️ Screenshots

Before

image

After

image

🚧 Tasks

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added 3. to review Waiting for reviews feature: select Related to the NcSelect* components accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Oct 4, 2023
@ShGKme ShGKme added this to the 8.0.0 milestone Oct 4, 2023
@ShGKme ShGKme self-assigned this Oct 4, 2023
@susnux susnux merged commit 628aaab into master Oct 4, 2023
15 checks passed
@susnux susnux deleted the fix/nc-select-duplicated-uid branch October 4, 2023 19:47
@Pytal Pytal added the bug Something isn't working label Oct 6, 2023
@Pytal Pytal mentioned this pull request Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: select Related to the NcSelect* components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BITV] 9.4.1.1/0.2 On the page, there are multiple IDs that are identical - see "resourceNameFintestExplorer".
4 participants