-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NcEmptyContent)!: make empty content centered by default instead of 20vh margin #4506
Conversation
It was the old behaviour, but to be honest, maybe just make it centered straight away? |
We can, but it will be a breaking change. Centered works well when component's user stretch it and the way it's been streatched may depends on a specific layout. For example, |
Agree with @skjnldsv that it should ideally be default instead of manually set prop. :) |
v8 is still in beta and breaking, I think we can go there imho :) |
fb686de
to
16e756d
Compare
PR is updated. Now it is centered by default. It works fine in all other But it is a breaking change, in apps in parents without height and flex it will have not top margin now. |
Missclick >< |
BREAKING CHANGE: there is no longer `margin-top: 20vh`. You should ajust position by setting container height of using flex container. Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
- Remove unnecessary margin:0 styles Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
16e756d
to
a485280
Compare
/backport to next Edit: I guess the backport bot is still dead. |
Yes, we didn't find the time yet... |
☑️ Resolves
By default
NcEmptyContent
displays the content with fixed 20vh top margin. This doesn't look good sometimes. I think that could be useful to have centeredNcEmptyContent
.For example, by default, it looks bad in comments, where the default margin is overridden now with
!important
.!important
overridecentered
Or in Talk.
🖼️ Screenshots
Also still works:
🚧 Tasks
margin-top: 20vh
flex: 1
to make it centered by default in flex parentsNcHeaderMenu
,NcDashboardWidget
- custom styles, nothing breakingNcAppSidebar
- works fine by default because of flexNcReferencePicker
:NcProviderList
,NcRawLinkInput
,NcSearch
- remove unnecessarymargin: 0
, works fine now by default🏁 Checklist