Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NcRichContenteditable: fix IME support on Mac OSX #4294

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jun 30, 2023

☑️ Resolves

Confirm entering during composition session in IME on Mac OSX is considered by <NcRichContenteditable> as Enter and emits submit during the input.

Reproducible on Safari and Chromium on Mac.
Not reproducible on Linux or Windows.

🖼️ Screenshots

🏚️ Before 🏡 After
Before-IME After-IME

🚧 Tasks

  • Add detection of composition session
  • Ignore Enter in composition session
  • Add test for this case and some other basic unit tests

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@ShGKme ShGKme added 3. to review Waiting for reviews feature: rich-contenteditable Related to the rich-contenteditable components labels Jun 30, 2023
@ShGKme ShGKme added this to the 8.0.0 milestone Jun 30, 2023
@ShGKme ShGKme self-assigned this Jun 30, 2023
@ShGKme ShGKme changed the title NcRichContenteditable: fix IME support on OSX NcRichContenteditable: fix IME support on Mac OSX Jun 30, 2023
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't test it properly on Linux, but according to MDN docs composition listeners seem legit to use. Tests are also look good from the code

@ShGKme ShGKme force-pushed the fix/richcontenteditable-IME-support branch from d697d21 to 0d76c9e Compare June 30, 2023 19:46
@ShGKme
Copy link
Contributor Author

ShGKme commented Jun 30, 2023

Rebased onto master with conflict resolve and test assert uncomment

@ShGKme ShGKme requested a review from Pytal July 6, 2023 15:44
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the fix/richcontenteditable-IME-support branch from 0d76c9e to 990532c Compare July 11, 2023 12:12
@ShGKme
Copy link
Contributor Author

ShGKme commented Jul 11, 2023

Just rebased onto master before merge, no changes.

@ShGKme ShGKme enabled auto-merge July 11, 2023 12:13
@ShGKme
Copy link
Contributor Author

ShGKme commented Jul 11, 2023

/backport to stable7

@ShGKme ShGKme merged commit a780d4a into master Jul 11, 2023
15 checks passed
@ShGKme ShGKme deleted the fix/richcontenteditable-IME-support branch July 11, 2023 12:15
@backportbot-nextcloud
Copy link

The backport to stable7 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable7
git pull origin stable7

# Create the new backport branch
git checkout -b fix/foo-stable7

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable7

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews feature: rich-contenteditable Related to the rich-contenteditable components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants