-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NcRichContenteditable: fix IME support on Mac OSX #4294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't test it properly on Linux, but according to MDN docs composition
listeners seem legit to use. Tests are also look good from the code
d697d21
to
0d76c9e
Compare
Rebased onto master with conflict resolve and test assert uncomment |
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
0d76c9e
to
990532c
Compare
Just rebased onto master before merge, no changes. |
/backport to stable7 |
The backport to stable7 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable7
git pull origin stable7
# Create the new backport branch
git checkout -b fix/foo-stable7
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable7 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
☑️ Resolves
Confirm entering during composition session in IME on Mac OSX is considered by
<NcRichContenteditable>
as Enter and emitssubmit
during the input.Reproducible on Safari and Chromium on Mac.
Not reproducible on Linux or Windows.
🖼️ Screenshots
🚧 Tasks
🏁 Checklist