Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AppSidebar. fix error when no tabs #359

Merged
merged 1 commit into from
Apr 20, 2019
Merged

AppSidebar. fix error when no tabs #359

merged 1 commit into from
Apr 20, 2019

Conversation

korelstar
Copy link
Contributor

There was an error when a AppSidebar doesn't contain any AppSidebarTabs and uses just the content directly.

See #340 (comment)

@korelstar korelstar added bug Something isn't working 3. to review Waiting for reviews feature: app-sidebar Related to the app-sidebar component labels Apr 19, 2019
@korelstar korelstar added this to the next milestone Apr 19, 2019
@korelstar korelstar requested a review from skjnldsv April 19, 2019 17:31
@korelstar korelstar mentioned this pull request Apr 19, 2019
Merged
skjnldsv
skjnldsv approved these changes Apr 20, 2019
View reviewed changes
Copy link
Contributor

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥰

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 20, 2019
@skjnldsv skjnldsv merged commit 9925674 into master Apr 20, 2019
@skjnldsv skjnldsv deleted the fix-sidebar-tabs branch April 20, 2019 08:12
@skjnldsv skjnldsv modified the milestones: next, 0.11.0 May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working feature: app-sidebar Related to the app-sidebar component
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@korelstar @skjnldsv