Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable5] Fix vue material design icons HTML validation #2921

Merged
merged 2 commits into from
Aug 3, 2022
Merged

[stable5] Fix vue material design icons HTML validation #2921

merged 2 commits into from
Aug 3, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Aug 2, 2022 •
edited by nickvergessen
Loading

  • ⚠️ This backport had conflicts and is incomplete ⚠️

backport of #2833

@nickvergessen @backportbot-nextcloud
Fix vue material design icons HTML validation
2ab4c1b 
Since v5.0.0 of the lib, the property decorative has been removed.
This means the "decorative" is added to the span element, causing the
HTML validation to fail:

> Attribute decorative not allowed on element span at this point.

Upstream commit
robcresswell/vue-material-design-icons@c65d8ea

> This patch also removes the default title, encouraging better
> accessibility by removing unhelpful titles that dont indicate usage. The
> `decorative` prop has been removed and any icons that do not have a
> meaningful title will be hidden from screen readers.

Signed-off-by: Joas Schilling <coding@schilljs.com>
@backportbot-nextcloud backportbot-nextcloud bot added accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working labels Aug 2, 2022
@backportbot-nextcloud backportbot-nextcloud bot added this to the 5.4.0 milestone Aug 2, 2022
@nickvergessen nickvergessen self-assigned this Aug 2, 2022
@nickvergessen
Fix more icons
15b14a7 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added the 3. to review Waiting for reviews label Aug 3, 2022
marcoambrosini
marcoambrosini approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

giphy

@nickvergessen nickvergessen merged commit 32cc11e into stable5 Aug 3, 2022
@nickvergessen nickvergessen deleted the backport/2833/stable5 branch August 3, 2022 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@mejo- mejo- Awaiting requested review from mejo-

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working
Projects
None yet
Milestone
5.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@marcoambrosini @nickvergessen