Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HTML validation of AppNavigationToggle #2846

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Fix HTML validation of AppNavigationToggle #2846

merged 1 commit into from
Jul 18, 2022

Conversation

nickvergessen
Copy link
Contributor

Error: Attribute icon not allowed on element button at this point.

@nickvergessen
Fix HTML validation of AppNavigationToggle
de5b332 
Error: Attribute icon not allowed on element button at this point.

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added bug Something isn't working 3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Jul 15, 2022
@nickvergessen nickvergessen added this to the 5.3.2 milestone Jul 15, 2022
JuliaKirschenheuter
JuliaKirschenheuter requested changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope i've understtod the problem right. Question: why not to fix this in https://github.com/nextcloud/nextcloud-vue/blob/de5b332374428795cac78b2a534af02ead8b0af0/src/components/ActionButton/ActionButton.vue#L79 and use src/components/Button/Button.vue instead?

My suggestin is that we still need an ActionButton inside of AppNavigationToggle. But i also could be wrong.

@nickvergessen
Copy link
Contributor Author

The Actions menu with 1 entry is a "hack" from before we had the buttons component. We should use the button component directly to ease the code.
Yeah ultimately also the Actions should use the Button component directly, but due to the huge list of things to do I would like to fix one thing at a time. Redoing Actions to use Button takes a lot more time then fixing this simple usage.

@nickvergessen nickvergessen merged commit 857c77e into master Jul 18, 2022
@nickvergessen nickvergessen deleted the bugfix/noid/fix-app-navigation-toggle branch July 18, 2022 13:12
This was referenced Jul 23, 2022
Closed
Merged
@juliusknorr juliusknorr modified the milestones: 5.3.2, 6.0.0 Aug 2, 2022
@juliusknorr juliusknorr mentioned this pull request Aug 2, 2022
Closed
@nickvergessen
Copy link
Contributor Author

/backport to stable5

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Aug 2, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@Pytal Pytal Pytal approved these changes

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees
No one assigned
Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nickvergessen @JuliaKirschenheuter @Pytal @juliusknorr