-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add headline to sidebar sections to improve landmarks #2845
Add headline to sidebar sections to improve landmarks #2845
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, since AppSidebar would have <h2>
heading, we could use here <h3>
as direct child. In this case it is also not possible to use role="heading" + aria-level
-> and it is ok to use <h3>
with class="hidden-visually"
> Section lacks heading. Consider using h2-h6 elements to add identifying > headings to all sections, or else use a div element instead for any > cases where no heading is needed. Signed-off-by: Joas Schilling <coding@schilljs.com>
1f15d43
to
57bae6d
Compare
Fixed code style
|
/backport to stable5 |
Signed-off-by: Joas Schilling coding@schilljs.com