-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
small cleanup of small modal size #2629
Conversation
Could you explain the reasoning behind this? |
width: 390px; | ||
max-width: 95%; | ||
width: 400px; | ||
max-width: 90%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing 390px to 400px is just for the sake of using a x00 number here instead of a random feeling number. Changing 95% to 90% is in order to align with the other used max values of mostly 90%.
&:not(&--small) .modal-container { | ||
.modal-container { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing this media query to also address the small modal has the reason that I designed the small modal initially to be used e.g. for prompts with a limited height. In reality it gets used in many places mostly with a pretty big height. Adjusting this makes sure that the mobile view is aligned to the other sizes and also looks better, imo.
done |
conflicts |
Signed-off-by: szaimen <szaimen@e.mail.de>
73bd0c2
to
fd3d425
Compare
Signed-off-by: szaimen szaimen@e.mail.de