Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow put custom label to ActionRadio.vue #2626

Conversation

JuliaKirschenheuter
Copy link
Contributor

resolves nextcloud/mail#1626

This is needed for extended labels as nextcloud/mail#1626 (comment)

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@miaulalala miaulalala self-requested a review April 8, 2022 10:14
Copy link
Contributor

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChristophWurst
Copy link
Contributor

I understand that this is a higher impact change but I don't see why it's bad per se.

Right now you can only use pure text for the label and no more specific markup.

The proposed alternative is to use a combination of action radio and action text. The difference I see is that with the alternative the actions are not grouped so that clicking the subline would also automatically select the radio. Only clicking the radio label selects the option.

I'm well aware that using a slot gives developers possible ways to create markup that isn't valid anymore.

Is there any other downside?

@skjnldsv
Copy link
Contributor

skjnldsv commented Apr 8, 2022

A radio label can only contains text, anything else is not valid for html.
This has a much higher impact. We use the double-action in a various other places and it works fine.

This is not a bad idea per se, but needs a much broader discussion regarding how we view the Actions in general and how do we make sure the component stays compliant to html/accessibility standards as well as NC design standards :)

@JuliaKirschenheuter JuliaKirschenheuter deleted the enhencement/1626-allow-put-custom-label-to-action-radio branch April 11, 2022 06:40
@JuliaKirschenheuter JuliaKirschenheuter added the discussion Need advices, opinions or ideas on this topic label Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Need advices, opinions or ideas on this topic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send scheduled / time-controlled mail
4 participants