-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make emojis selectable by tab #2552
Conversation
a265d89
to
dfda150
Compare
dfda150
to
0500edf
Compare
0500edf
to
1620e07
Compare
Looks good! :)
Not sure about this, I think arrow keys can be used to select emojis and categories also. Tab can used to change focus between categories, search, and emojis. Within that you navigate using arrow keys. Also a couple more points from me:
cc @jancborchardt if there is anything else to add |
Not sure those two are doable |
Only a detail from my side: Would look nicer to have the focus box be a circle instead of a square with rounded corners? :) |
048c2d4
to
23d20c4
Compare
This comment was marked as resolved.
This comment was marked as resolved.
23d20c4
to
c9e9680
Compare
/rebase |
b5537e8
to
79a6558
Compare
075cac0
to
79a6558
Compare
79a6558
to
f6f4caa
Compare
349650b
to
79528e5
Compare
@nimishavijay & @jancborchardt can you check again if the picker looks good and works as expected like it is now?
|
Approval from my side, you can self-approve on my behalf @vanpertsch |
79528e5
to
6069b97
Compare
Signed-off-by: Vanessa Pertsch <vanessa.pertsch@nextcloud.com> Signed-off-by: Vanessa Pertsch <vanessa.pertsch@posteo.de>
6069b97
to
225f5a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 :)
Signed-off-by: Vanessa Pertsch <vanessa.pertsch@posteo.de>
225f5a0
to
7e949a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
on open : Search is in focus
if search is in focus, emojis are selectable by arrow keys
Categories and emojis are selectable by tab
Is this the behavior we want to see?