Button!

[marcoambrosini]

Requires nextcloud/server#25774
Test with nextcloud/spreed#6121

[marcoambrosini]

Yes, that's what I meant. I got a warning when I had both Button and a button in the same component. But I didn't further check on this problem to be honest.

Let's call it nc-button? cc @skjnldsv @juliushaertl

Great, it's fine for me. I was just wondering, sorry.

No worries, that's on me :)

[raimund-schluessler]

Yes, that's what I meant. I got a warning when I had both Button and a button in the same component. But I didn't further check on this problem to be honest.

Let's call it nc-button? cc @skjnldsv @juliushaertl

I thought about this again and I think one can just import/mount the Button component under a different name in case there is a clash between the button tag and the Button component. So I guess it's a matter of taste if we rename it or not. It should work either way.

[juliusknorr]

Very nice 👍

[ChristophWurst]

Code looks good

[raimund-schluessler]

I guess this will be in nextcloud/vue@4.3.0 since it is not a breaking change.

But due to nextcloud/server#25774 using the Button component will require Nextcloud 22.2.1 or higher. How do we handle this, and could we maybe backport nextcloud/server#25774 to stable21 and stable20 as well (since they are still supported)?

[ChristophWurst]

I guess this will be in nextcloud/vue@4.3.0 since it is not a breaking change.

This new component doesn't work with older versions of Nextcloud. This is a breaking change IMO. I would make a clear cut with a major release.

Ref nextcloud/server#25774 (comment)

[raimund-schluessler]

This new component doesn't work with older versions of Nextcloud. This is a breaking change IMO. I would make a clear cut with a major release.

But it also doesn't break anything for apps that upgrade, since the component simply wasn't available before 🙈. I guess it's a matter of interpretation under which version number we release it.

The more severe problem is which server version will be compatible. If we really don't backport, many apps (e.g. Calendar, Tasks, Maps, Contacts, all which support all server versions with a single release) will only be able to use the button component (or strictly speaking, updating to nc-vue@5.0.0) once server v23 is the oldest supported version (July 2022). This will make the component quite useless until then.

Is there maybe the possibility to make the Button component self-contained (i.e. not dependent on a specific server version), by including all CSS properties and variables in nc-vue? That way, it could be used with any server version.

[marcoambrosini]

Is there maybe the possibility to make the Button component self-contained (i.e. not dependent on a specific server version), by including all CSS properties and variables in nc-vue? That way, it could be used with any server version.

It heavily relies on the theming engine in the server. This is something we will encounter every time we'll have to add new Colors, I don't think that bringing everything to the component's scoped styles is a good solution.

[raimund-schluessler]

Is there maybe the possibility to make the Button component self-contained (i.e. not dependent on a specific server version), by including all CSS properties and variables in nc-vue? That way, it could be used with any server version.

It heavily relies on the theming engine in the server. This is something we will encounter every time we'll have to add new Colors, I don't think that bringing everything to the component's scoped styles is a good solution.

That's up to Nextcloud to decide internally, I guess. It just means that this component is mainly useless until server v22 is EOL.