Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update action hover feedback #1692

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Update action hover feedback #1692

merged 1 commit into from
Feb 11, 2021

Conversation

marcoambrosini
Copy link
Contributor

@marcoambrosini marcoambrosini commented Feb 2, 2021

As discussed with @jancborchardt

Peek 2021-02-02 14-50

Signed-off-by: Marco Ambrosini marcoambrosini@pm.me

Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
@marcoambrosini marcoambrosini self-assigned this Feb 2, 2021
@marcoambrosini marcoambrosini added 3. to review Waiting for reviews design Design, UX, interface and interaction design bug Something isn't working labels Feb 2, 2021
Copy link
Contributor

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in talk

@nickvergessen
Copy link
Contributor

In the second you click it looks like all feedback is missing?

@marcoambrosini
Copy link
Contributor Author

In the second you click it looks like all feedback is missing?

The behavior is exactly the same as now, I'm only changing appearance of the feedback

Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GretaD GretaD merged commit 324125c into master Feb 11, 2021
@GretaD GretaD deleted the update-action-hover-feedback branch February 11, 2021 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working design Design, UX, interface and interaction design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants