Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2] Add changelog file #1611

Merged
merged 3 commits into from
Nov 30, 2020
Merged

[stable2] Add changelog file #1611

merged 3 commits into from
Nov 30, 2020

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Nov 26, 2020

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #1605

Copied entries from Github Releases up to 2.6.0.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81
Copy link
Contributor

I looked at how we do it in the Talk repo and it seems that on stable branches we only include entries relevant to that branch and older, so I'm going to edit this here accordingly

Only include entries from the stable branch's major version and earlier.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81
Copy link
Contributor

ok, so conflict solved: I've synced this branch's README with the one from master and replaced s/master/stable2/

please review!

@PVince81 PVince81 self-assigned this Nov 26, 2020
@PVince81 PVince81 added the 3. to review Waiting for reviews label Nov 26, 2020
@PVince81
Copy link
Contributor

some weird stuff here

Error: Unable to process command '::set-env name=TERM::xterm' successfully.
Error: The `set-env` command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the `ACTIONS_ALLOW_UNSECURE_COMMANDS` environment variable to `true`. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

maybe need to update the CI pipeline config on stable2

@skjnldsv
Copy link
Contributor

maybe need to update the CI pipeline config on stable2

https://github.com/nextcloud/nextcloud-vue/blob/d64d06e568b3c8f248dc1d3447ca0b56ab6c3589/.github/workflows/cypress.yml#L38
Needs to use v2

@PVince81
Copy link
Contributor

maybe need to update the CI pipeline config on stable2

https://github.com/nextcloud/nextcloud-vue/blob/d64d06e568b3c8f248dc1d3447ca0b56ab6c3589/.github/workflows/cypress.yml#L38

Needs to use v2

requested backport: #1548 (comment)

@PVince81 PVince81 merged commit 198e779 into stable2 Nov 30, 2020
@PVince81 PVince81 deleted the backport/1605/stable2 branch November 30, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants