Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup avatar fetching methods #1489

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Cleanup avatar fetching methods #1489

merged 1 commit into from
Oct 19, 2020

Conversation

skjnldsv
Copy link
Contributor

Pretty much does the same, just a code cleanup!

@skjnldsv skjnldsv added 3. to review Waiting for reviews feature: avatar Related to the avatar component labels Oct 19, 2020
@skjnldsv skjnldsv self-assigned this Oct 19, 2020
@PVince81
Copy link
Contributor

will clash with #1457 :-/

@PVince81
Copy link
Contributor

needs rebase. thanks for approving the other one first 🙇

@skjnldsv
Cleanup avatar fetching methods
988eb3e 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Copy link
Contributor Author

Done

PVince81
PVince81 approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks fine, still works 👍

@skjnldsv skjnldsv merged commit 1283661 into master Oct 19, 2020
@skjnldsv skjnldsv deleted the fix/avatar-cleanup branch October 19, 2020 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@GretaD GretaD GretaD approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@dartcafe dartcafe Awaiting requested review from dartcafe

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews feature: avatar Related to the avatar component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @PVince81 @GretaD