Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache hasAvatar info in sessionStorage to avoid flicker #1457

Merged
merged 2 commits into from
Oct 19, 2020
Merged

Cache hasAvatar info in sessionStorage to avoid flicker #1457

merged 2 commits into from
Oct 19, 2020

Commits on Oct 15, 2020

  1. Save server requests by caching hasAvatar globally 

    Improve performance by saving repeated HTTP calls when retrieving
information whether a user has an avatar set. Note that even HTTP calls
that hit the cache cause a delay.

This is useful to avoid flickering when switching/re-rendering vue
components that render avatars.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
    @PVince81
    PVince81 committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    15c7212 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2020

  1. Use browser storage for storaing hasAvatar state 

    Signed-off-by: Vincent Petry <vincent@nextcloud.com>
    @PVince81
    PVince81 committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    7613d44 View commit details
    Browse the repository at this point in the history