-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emoji picker suggestions are unexpected when using ":)" and ":D" #3825
Comments
In a different issue @nickvergessen mentioned to not replace :) or :D with emojis but keep them as is. Either is fine with me design-wise, as long as the completely-wrong-emoji issue is fixed. :D |
cc @max-nextcloud @mejo- one of you worked on the emoji picker, right? Maybe you know a possible solution here? |
The question is how. The problem origins from writing the emoji and then using "Enter" to send the chat message. But since you did type a I don't know how the emoji autocomplete works, maybe we can extend the list and add manual additional entries to it for some text based ones and make the plain text Apart from :) and :D there are at least 3 more, which at least affect me regularly:
|
Emoji picker already has the required data available, searching for The problem is that we actually search for The relevant place in code would be here: https://github.com/nextcloud/nextcloud-vue/blob/4690b32d23a451c8a67d711c8066b191008f2050/src/functions/emoji/emoji.js#L36 The following code change should do the trick: let results = index.search(`:${query}`, maxResults)
if (results.length < maxResults) {
results = results.concat(index.search(query, maxResults - results.length))
}
return results |
I can prepare a PR next week if others think this is a viable solution. |
Search for `:<search-query>` first and fill up missing results with `<search-query>` (stripping the `:`). This improves results for emoji autocompletion when typing emoticons (like `:)`, `:D`, `:P` and so on). Fixes: #3825 Signed-off-by: Jonas <jonas@freesources.org>
I went ahead and created a (untested) PR: #3923 |
Search for `:<search-query>` first and fill up missing results with `<search-query>` (stripping the `:`). This improves results for emoji autocompletion when typing emoticons (like `:)`, `:D`, `:P` and so on). Fixes: #3825 Signed-off-by: Jonas <jonas@freesources.org>
Search for `:<search-query>` first and fill up missing results with `<search-query>` (stripping the `:`). This improves results for emoji autocompletion when typing emoticons (like `:)`, `:D`, `:P` and so on). Fixes: #3825 Signed-off-by: Jonas <jonas@freesources.org>
I'll send a counter proposal soon to actually autocomplete the text as mentioned above instead of posting emojis |
When typing
:)
and:D
, two very common text emojis, the suggestions by the emoji picker are very off. And when you just press "enter", you get very misleading emojis as a result:Expected suggestions:
:slightly_smiling_face:
:smile:
The text was updated successfully, but these errors were encountered: