Merge pull request #3713 from nextcloud/fix/noid/navigation-caption-doc

Add aria-labels to example buttons in docs
nextcloud-libraries · Feb 2, 2023 · 1eb4344 · 1eb4344
2 parents 96f21f2 + 4a5c193
commit 1eb4344
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/components/NcAppNavigationCaption/NcAppNavigationCaption.vue b/src/components/NcAppNavigationCaption/NcAppNavigationCaption.vue
@@ -8,6 +8,7 @@
 					<template #icon>
 						<Plus :size="20" />
 					</template>
+					This is an action
 				</NcActionButton>
 			</template>
 		</NcAppNavigationCaption>

diff --git a/src/components/NcIconSvgWrapper/NcIconSvgWrapper.vue b/src/components/NcIconSvgWrapper/NcIconSvgWrapper.vue
@@ -30,27 +30,27 @@ Render raw SVG string icons.
 ```vue
 <template>
 	<div class="grid">
-		<NcButton>
+		<NcButton aria-label="Close">
 			<template #icon>
 				<NcIconSvgWrapper :svg="closeSvg" title="Close" />
 			</template>
 		</NcButton>
-		<NcButton>
+		<NcButton aria-label="Settings">
 			<template #icon>
 				<NcIconSvgWrapper :svg="cogSvg" title="Cog" />
 			</template>
 		</NcButton>
-		<NcButton>
+		<NcButton aria-label="Add">
 			<template #icon>
 				<NcIconSvgWrapper :svg="plusSvg" title="Plus" />
 			</template>
 		</NcButton>
-		<NcButton>
+		<NcButton aria-label="Send">
 			<template #icon>
 				<NcIconSvgWrapper :svg="sendSvg" title="Send" />
 			</template>
 		</NcButton>
-		<NcButton>
+		<NcButton aria-label="Star">
 			<template #icon>
 				<NcIconSvgWrapper :svg="starSvg" title="Star" />
 			</template>