Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

[vue3]: migrate package to Vue 3 #1224

Merged
merged 2 commits into from
Jun 17, 2024
Merged

[vue3]: migrate package to Vue 3 #1224

merged 2 commits into from
Jun 17, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jun 3, 2024 •
edited
Loading

Bump and audit dependencies:

  • Related:
    • vue
    • @nextcloud/vue
    • @nextcloud/vite-config

Migrate to Vue3:

  • replace Vue.set syntax
  • remove unused arguments

Tested with Talk vue3 branch:
image

@Antreesy Antreesy added dependencies Pull requests that update a dependency file breaking 3. to review labels Jun 3, 2024
@Antreesy Antreesy self-assigned this Jun 3, 2024
@Antreesy
Copy link
Contributor Author

Antreesy commented Jun 3, 2024

Perhaps I was a little hasty here. We can decide whether to:

  • release 0.13.0 directly from the vue3 branch (straight away),
  • or merge it into master first and do a release (this PR).

Given that this library is not very popular and is rarely updated, I would prefer the second option

@Antreesy Antreesy requested a review from ShGKme June 3, 2024 15:05
@susnux
Copy link
Contributor

susnux commented Jun 3, 2024

release 0.13.0 directly from the vue3 branch (straight away),

Probably better doing a major bump?

st3iny
st3iny reviewed Jun 4, 2024
View reviewed changes
Copy link

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'd also prefer a major bump.

@ShGKme
Copy link
Contributor

ShGKme commented Jun 10, 2024

  • release 0.13.0 directly from the vue3 branch (straight away),

This would trigger dependabot and result in an invalid bump

@ShGKme
Copy link
Contributor

ShGKme commented Jun 10, 2024

We can release it as v2 to have one major version just in case for breaking change in vue 2.

@susnux
Copy link
Contributor

susnux commented Jun 14, 2024

We can release it as v2 to have one major version just in case for breaking change in vue 2.

I do not think we need another major for vue2, as this basically sticks with 0.x anyways 😅

@Antreesy Antreesy changed the base branch from master to v0.13.0 June 14, 2024 19:10
@Antreesy
Copy link
Contributor Author

Antreesy commented Jun 14, 2024 •
edited by susnux
Loading

Rebased onto release branch (for now)

  • get approve on release PR v0.13.0
  • branch-off master to stable0
  • release v0.13.0 from stable0 branch
  • merge this PR to master
  • release v1.0.0, add comment to README.md about versions compatibility

@ShGKme
Copy link
Contributor

ShGKme commented Jun 14, 2024

Then let's branch of the current master as stable0 and then merge this to master and release as v1.0.0.

Releasing as v0.x will likely trigger dependabot/renovate as a valid safe upgrade.

Base automatically changed from v0.13.0 to master June 16, 2024 13:10
Antreesy and others added 2 commits June 16, 2024 15:41
@Antreesy @susnux
chore(deps): update dependencies to align with vue 3
65a877a 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@DorraJaouad @susnux
fix(vue3): remove deprecated Vue3 APIs, lint files
7990eb4 
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@susnux
Copy link
Contributor

susnux commented Jun 16, 2024

Rebased and tested, seems to work find :)

@Antreesy
Copy link
Contributor Author

Rebased and tested, seems to work find :)

Shall we note in Readme, that this version is for Vue3 now?

@susnux
Copy link
Contributor

susnux commented Jun 16, 2024

Shall we note in Readme, that this version is for Vue3 now?

Yes sounds good

@Antreesy Antreesy merged commit f90098e into main Jun 17, 2024
10 checks passed
@Antreesy Antreesy deleted the vue3 branch June 17, 2024 09:00
@Antreesy Antreesy mentioned this pull request Jul 4, 2024
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@st3iny st3iny st3iny left review comments

@susnux susnux susnux approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels
3. to review breaking dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Antreesy @susnux @ShGKme @st3iny @DorraJaouad