fix: Revert chunkFileNames to include hash #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
Pro of this:
Con of this:
I can live with both and I fear that simply patching |
susnux
approved these changes
Aug 2, 2024
susnux
reviewed
Aug 2, 2024
juliusknorr
force-pushed
the
fix/chunk-hash
branch
from
482318e
to
cef72bc
Compare
ShGKme
reviewed
Aug 2, 2024
susnux
approved these changes
Aug 2, 2024
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
|
/backport to stable1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the browser cache is not refetching updated files.
I noticed after the upgrade on our instance today that the files app was having weired styles, only a force refresh helped. Not sure this has been exactly this issue, but as I talked with someone before (likely @susnux) I thought I'd open that PR.