Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add notifier to watch upload and attach the File to the Upload #915

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

skjnldsv
Copy link
Contributor

  1. The queue reactivity have been fixed
  2. Because the reference is now kept, it means the watcher can NOT work as any array change will result in both the old and the new value to point to the same ref and have no differences
  3. Therefore we now have the ability to subscribe to those uploads

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv self-assigned this Aug 26, 2023
@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Merging #915 (d9db95c) into master (0b60bbb) will decrease coverage by 0.25%.
The diff coverage is 21.42%.

@@            Coverage Diff             @@
##           master     #915      +/-   ##
==========================================
- Coverage   34.89%   34.65%   -0.25%     
==========================================
  Files           6        6              
  Lines         192      202      +10     
  Branches       26       26              
==========================================
+ Hits           67       70       +3     
- Misses        123      130       +7     
  Partials        2        2              
Files Changed Coverage Δ
lib/uploader.ts 0.00% <0.00%> (ø)
lib/upload.ts 93.61% <75.00%> (+2.50%) ⬆️

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv merged commit 190c537 into master Aug 29, 2023
13 of 15 checks passed
@skjnldsv skjnldsv deleted the feat/notifiers branch August 29, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant