fix: getUploader should only be called when a new UploadPicker instance is created

[susnux]

Finally solved the issue with the @nextcloud/cypress update:

[skjnldsv]

Hum, I actually don't get why that would change anything ?
The uploader init is irrelevant to the Vue component. It doesn't matter if it's created before or while the vue component is initiated?

Commented

[susnux]

@skjnldsv because before this the bundled file looks like this:

const uploadManager = getUploader();
var UploadPicker = // ...
// ... more stuff ...
let _uploader = null
function getUploader() {
   /// ...
}

So as uploadManager is on the global scope, it will get initialized first by calling uploadManager() but _uploader was not declared at this time, as the interpreter is still on the uploadManager line.

With this changes it looks like this

var UploadPicker  = {
    // ...
    data() {
        uploadManager: getUploader(),
        // ...
    }
}
// ... more stuff ...
let _uploader = null
function getUploader() {
   /// ...
}

so this time everything is declared first before it is used.

To see the error in action you can try this exampel in Node or your browser console:

const uploadManager = getUploader()
let _uploader = null
function getUploader() {
   if (_uploader === null) return _uploader = 'uploader'
   return _uploader
}

The node error message is not that helpful I think:

ReferenceError: Cannot access '_uploader' before initialization

But on Firefox it makes sense:

Uncaught ReferenceError: can't access lexical declaration '_uploader' before initialization

[susnux]

Found the reason for the cypress issue here and fixed that :)

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (c466817) 33.50% compared to head (d00589a) 33.50%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #887   +/-   ##
=======================================
  Coverage   33.50%   33.50%           
=======================================
  Files           6        6           
  Lines         200      200           
  Branches       31       31           
=======================================
  Hits           67       67           
  Misses        131      131           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[skjnldsv]

Wow, this is very interesting!
The import order does make a difference in bundling, TIL