Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cannot access _uploader before initialization #879

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 6, 2023

If the variable is declared using let or const we need to initialize it explicitly before it can be accessed - even if we access it using instanceof.

So current beta.9 is not usable :/

If the variable is declared using `let` or `const` we need to initialize it explicitly
before it can be accessed - even if we access it using `instanceof`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug Something isn't working 3. to review Waiting for reviews labels Jul 6, 2023
@susnux susnux requested a review from skjnldsv July 6, 2023 00:46
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (af4f4ac) 33.50% compared to head (327cf57) 33.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #879   +/-   ##
=======================================
  Coverage   33.50%   33.50%           
=======================================
  Files           6        6           
  Lines         200      200           
  Branches       31       31           
=======================================
  Hits           67       67           
  Misses        131      131           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@skjnldsv skjnldsv merged commit 32fb66f into master Jul 6, 2023
@skjnldsv skjnldsv deleted the fix/uninitialized branch July 6, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants