Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make the default uploader global #1370

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Sep 4, 2024

This way it is possible e.g. for files_sharing and files to share the same uploader instance.

@susnux susnux added bug Something isn't working 3. to review Waiting for reviews labels Sep 4, 2024
@susnux susnux requested a review from skjnldsv September 4, 2024 14:58
@susnux susnux force-pushed the fix/make-uploader-global branch 2 times, most recently from 513b2d1 to be3ae8a Compare September 4, 2024 15:11
Copy link

codecov bot commented Sep 4, 2024

Bundle Report

Changes will increase total bundle size by 129 bytes ⬆️

Bundle name Size Change
@nextcloud/upload-esm 359.09kB 51 bytes ⬆️
@nextcloud/upload-esm-cjs 362.16kB 78 bytes ⬆️

This way it is possible e.g. for `files_sharing` and `files` to share the same uploader instance.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux merged commit a7a2348 into main Sep 5, 2024
17 checks passed
@susnux susnux deleted the fix/make-uploader-global branch September 5, 2024 12:35
@susnux susnux mentioned this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants