Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: also run node on main push #1367

Merged
merged 2 commits into from
Sep 4, 2024
Merged

chore: also run node on main push #1367

merged 2 commits into from
Sep 4, 2024

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Sep 4, 2024

Signed-off-by: John Molakvoæ skjnldsv@users.noreply.github.com

Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Copy link

codecov bot commented Sep 4, 2024

Bundle Report

Changes will increase total bundle size by 35.1kB ⬆️

Bundle name Size Change
@nextcloud/upload-esm 358.28kB 17.55kB ⬆️
@nextcloud/upload-esm-cjs 361.36kB 17.55kB ⬆️

@skjnldsv skjnldsv self-assigned this Sep 4, 2024
@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Sep 4, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

push:
branches:
- main
- master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be not needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copied from node-test.yml 🤷

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I agree

@skjnldsv skjnldsv merged commit 7ac5ca6 into main Sep 4, 2024
17 checks passed
@skjnldsv skjnldsv deleted the skjnldsv-patch-1 branch September 4, 2024 11:46
@susnux susnux mentioned this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants