Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(uploader): Allow to specify custom headers #1366

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Sep 4, 2024

Use case: file-request need to set X-NC-Nickname header on upload.

@susnux susnux added enhancement New feature or request 3. to review Waiting for reviews labels Sep 4, 2024
Copy link

codecov bot commented Sep 4, 2024

Bundle Report

Changes will increase total bundle size by 36.52kB ⬆️

Bundle name Size Change
@nextcloud/upload-esm 359.01kB 18.27kB ⬆️
@nextcloud/upload-esm-cjs 362.06kB 18.25kB ⬆️

@susnux
Copy link
Contributor Author

susnux commented Sep 4, 2024

Changes will increase total bundle size by 36.52kB ⬆️

No my 🤖 friend it is only 700bytes...

Use case: file-request need to set `X-NC-Nickname` header on upload.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@skjnldsv skjnldsv merged commit 0146ba9 into main Sep 4, 2024
17 checks passed
@skjnldsv skjnldsv deleted the feat/allow-custom-headers branch September 4, 2024 11:49
@susnux susnux mentioned this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants