feat(UploadPicker): Use @nextcloud/files filename validation by default
#1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle ReportChanges will increase total bundle size by 10.37kB ⬆️
|
susnux
force-pushed
the
feat/validate-filename
branch
3 times, most recently
from
0e79542
to
884754e
Compare
…ault This allows to make use of Nextcloud 30 server capabilities. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
feat/validate-filename
branch
from
884754e
to
40213fd
Compare
skjnldsv
reviewed
Aug 6, 2024
Comment on lines
+13
to
+19
| <NcTextField v-if="canRename" | ||
| ref="textfield" | ||
| class="invalid-filename-dialog__input" | ||
| :error="!isValidName" | ||
| :helper-text="validationError" | ||
| :label="t('New filename')" | ||
| :value.sync="newName" /> |
There was a problem hiding this comment.
I would also like default html validation.
From an accessibility perspective, I think it's best
minlenght ? maxlength ?
Ther's also no form with submit, I think this is important for accessibility ?
skjnldsv
approved these changes
Aug 6, 2024
susnux
commented
Aug 6, 2024
| } finally { | ||
| const textfield = (this.$refs.textfield as ComponentPublicInstance)?.$el.querySelector('input') | ||
| if (textfield) { | ||
| textfield.setCustomValidity(this.validationError) |
There was a problem hiding this comment.
@skjnldsv it is set here as HTML validation
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to make use of Nextcloud 30 server capabilities ("Windows support").
We keep the legacy options to be non breaking, but we can cleanup logic once we do a major release.