Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: prepare release 1.4.2 #1281

Merged
merged 1 commit into from
Jul 11, 2024
Merged

chore: prepare release 1.4.2 #1281

merged 1 commit into from
Jul 11, 2024

Conversation

Antreesy
Copy link
Contributor

v1.4.2 (2024-07-11)

Full Changelog

Fixed

Changed

  • chore: Add SPDX header #1278 (AndyScherzinger)
  • chore: Add transifex-conventional-rebase.yml
  • chore: Bump typedoc from 0.25.13 to 0.26.4
  • chore: Bump @nextcloud/dialogs from 5.3.2 to 5.3.5
  • chore: Bump vite from 5.3.1 to 5.3.3
  • chore: Bump @types/node from 20.14.7 to 20.14.10
  • chore: Bump cypress from 13.12.0 to 13.13.0
  • chore: Bump vitest and @vitest/coverage-v8
  • chore: Bump actions/setup-node from 4.0.2 to 4.0.3
  • Updates for project Nextcloud upload library

v1.4.1 (2024-06-24)

Full Changelog

@Antreesy Antreesy added the 4. to release Ready to be released and/or waiting for tests to finish label Jul 11, 2024
@Antreesy Antreesy self-assigned this Jul 11, 2024
juliusknorr
juliusknorr requested changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog file also needs an update ;)

@Antreesy
Copy link
Contributor Author

Antreesy commented Jul 11, 2024 •
edited
Loading

Changelog file also needs an update ;)

I added it first, then saw the red CI and thought by the flow it's gonna be autogenerated..

Screenshot_2024-07-11-12-20-17-317-edit_com.github.android.jpg

@susnux
Copy link
Contributor

susnux commented Jul 11, 2024

I added it first, then saw the red CI and thought by the flow it's gonna be autogenerated..

I think the CI hung up because of your branch name, the tag ref is now blocked by your name, possibly always scope your branches like chore/v1.4.2

@susnux
Copy link
Contributor

susnux commented Jul 11, 2024

(or it fetches from API and your draft sets the latest version to 1.4.2 which is obviously not correct 😅 )

@Antreesy @susnux
chore: prepare release 1.4.2
a2f4be1 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@susnux susnux requested a review from juliusknorr July 11, 2024 10:42
@Antreesy
Copy link
Contributor Author

possibly always scope your branches like chore/v1.4.2

Ah, good to know. I'm usually following vue-library instructions

@Antreesy Antreesy merged commit e50a1a2 into main Jul 11, 2024
15 of 16 checks passed
@Antreesy Antreesy deleted the v1.4.2 branch July 11, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@Antreesy Antreesy

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @susnux @juliusknorr