feat: allow to specify the root of an upload #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
5 tasks
susnux
reviewed
Apr 2, 2024
| upload(destinationPath: string, file: File): PCancelable<Upload> { | ||
| const destinationFile = `${this.root}/${destinationPath.replace(/^\//, '')}` | ||
| upload(destinationPath: string, file: File, root?: string): PCancelable<Upload> { | ||
| const destinationFile = `${root || this.root}/${destinationPath.replace(/^\//, '')}` |
There was a problem hiding this comment.
Not sure if it makes sense to do so, but this would also allow an empty root:
Suggested change
| const destinationFile = `${root || this.root}/${destinationPath.replace(/^\//, '')}` | |
| const destinationFile = `${root ?? this.root}/${destinationPath.replace(/^\//, '')}` |
There was a problem hiding this comment.
Right, we should probably not allow empty root 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allow us to not have to change the current uploader destination.
Needed for nextcloud/server#44409